jkuntz
January 8, 2024, 9:49pm
1
Both my developer and myself have tried to get the theme deploy working from GitHub, and it’s failing without details of why (that I can see at least). I reviewed the issues log for the action on TryGhost on GitHub for others with similar issues but wasn’t sure where to go from here. I’m referencing the latest version I believe but it still fails.
The deploy-theme.yml is:
At first I thought it was spaces in the folder name so I renamed it too. I’ve tried the working-directory with and without the ./ as well as with and without quotes.
1 Like
Can you share a link to the logs if they’re public?
jkuntz
January 9, 2024, 12:44am
3
Hi,
The repo is not public but I have pasted the contents here, snipping some parts to make the character count fit. Does that help?
Jen
2024-01-08T21:40:57.9848689Z Requested labels: ubuntu-22.04runner-images/images/ubuntu/Ubuntu2204-Readme.md at ubuntu22/20240107.1 · actions/runner-images · GitHub Release Ubuntu 22.04 (20240107) Image Update · actions/runner-images · GitHub https://github.com/jenkuntz/Website-jenkuntz-Ghost https://github.com/.extraheader ’ || :”https://github.com/.extraheader AUTHORIZATION: basic ***https://github.com/jenkuntz/Website-jenkuntz-Ghost https://github.com/.extraheader https://github.com/.extraheader https://github.com/.extraheader ’ || :”
It does help to confirm that the GitHub UI isn’t being weird
Can you confirm that SaimaThemeFiles exists in the associated commit (e.g. https://github.com/jenkuntz/Website-jenkuntz-Ghost/tree/aebe3c545158625c2dcc207f2f1f2b06246154bf/SaimaThemeFiles)? And if so, what files exist there?
jkuntz
January 9, 2024, 1:50am
5
OK I found the path https://github.com/jenkuntz/Website-jenkuntz-Ghost/tree/aebe3c545158625c2dcc207f2f1f2b06246154bf/SaimaThemeFiles and this is what’s in it, all theme files that I would otherwise zip up and upload manually.
Okay, that’s good to see. Another thing to check - have you tried re-running the job (or against multiple commits)? Hopefully it’s a glitch before we start looking into the Action’s behavior
Thanks for trying, that exit code 1 from the debug log was helpful. It looks like any errors that come from the action are getting masked right now (cc @RyanF )
In the meantime, I’ve created a hacked version of the action to properly log the error - here is the diff for reference: Comparing TryGhost:main...vikaspotluri123:tmp-hack-error · TryGhost/action-deploy-theme · GitHub
Can you try with this version to get the actual error? Replace TryGhost/action-deploy-theme* with vikaspotluri123/action-deploy-theme@tmp-hack-error in your action.
jkuntz
January 9, 2024, 10:36pm
9
Thank you, sorry for the delayed response. SUCCESS!
It says invalid URL, shouldn’t have a trailing slash. After removing the trailing slash from the URL in secrets the deploy succeeded. Thank you very much. Is whatever you modified to show the error something you’re going to update about the actual deploy action?
Interestingly enough, copying the value from Ghost Admin’s Integrations section visually has no trailing slash but pasting it contains a slash. My humble guess is users would never know to remove that.
I reset the deploy back to TryGhost/… and it continues to deploy successfully now.
Thank you so much! I appreciate all of your responses to help me with this.
2 Likes
I hacked the output to ungate you, but I’m going to defer to the primary maintainers of the action to determine the proper solution - the error was masked because the code was trying to print it in a standard format.
What version of Ghost are you using? I tried locally and I got the URL without a trailing slash, even if I configured my URL with a trailing slash.
1 Like
RyanF
January 10, 2024, 8:07am
11
@vikaspotluri123 Thanks for figuring this out! Do you know what part of the console statement causes the masking?
I think the error needs to be stringified (e.g. using util.inspect) prior to being passed to JSON.serialize
jkuntz
January 10, 2024, 5:20pm
13
I’m using Ghost Pro not self hosted Ghost, so whatever version that is…
I was using my iPad so will try on my laptop this afternoon to see if I can reproduce it there, it was odd for sure.
1 Like
You can get your Ghost version by heading to Settings → scroll all the way down in the left sidebar and click the Ghost logo (or /ghost/#/settings/about)
jkuntz
January 10, 2024, 6:11pm
15
Thanks. 5.75.1+moya is what it says.
Regarding the copy/paste thing, I cannot reproduce it from the laptop, so copying on mobile might somehow add the trailing slash. Anyway, if it was a weird scenario that only I happened to run into, others may not!
Thanks again for all your help.
2 Likes
Sometimes it won’t show the logs for a step, even if the step had logs.
