Hello, I have cloned Ghost and attempted to run yarn test and there are two test failures. I haven’t make any changes to the Ghost code base.
I am up to date with the latest commit from today. e6f9fce99abd4e3cba06a35e21aed8920ccd7db3
My steps were
- How was Ghost installed and configured?
git clone --recurse-submodules git@github.com:TryGhost/Ghost && cd Ghost
yarn setup
yarn test
-
What Node version, database, OS & browser are you using?
Node Version: v16.19.1
From package.json the db seems to be “sqlite3”: “5.1.6”
MacBook Pro 13" 2 GHz Quad-Core Intel Core i5 -
What errors or information do you see in the console?
1) SlackNotifications
notifyMilestoneReceived
Sends a notification to Slack for achieved ARR Milestone - no meta:
AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
assert(sendStub.calledWith(expectedResult, 'https://slack-webhook.example') === true)
+ expected - actual
-false
+true
at Context.<anonymous> (test/SlackNotifications.test.js:104:13)
1) MembersStatsService
getCountHistory
Always returns at least one value:
AssertionError [ERR_ASSERTION]: Expected values to be loosely deep-equal:
{
comped: 3,
date: '2000-01-09',
free: 2,
paid: 1,
paid_canceled: 0,
paid_subscribed: 0
}
should loosely deep-equal
{
comped: 3,
date: '2000-01-10',
free: 2,
paid: 1,
paid_canceled: 0,
paid_subscribed: 0
}
+ expected - actual
{
"comped": 3
- "date": "2000-01-09"
+ "date": "2000-01-10"
"free": 2
"paid": 1
"paid_canceled": 0
"paid_subscribed": 0
at Context.<anonymous> (test/lib/members.test.js:132:20)
2) MembersStatsService
getCountHistory
Passes paid_subscribers and paid_canceled:
AssertionError [ERR_ASSERTION]: Expected values to be loosely deep-equal:
[
{
comped: 3,
date: '2000-01-09',
free: 2,
paid: 1,
paid_canceled: 0,
paid_subscribed: 0
}
]
should loosely deep-equal
[
{
comped: 0,
date: '2000-01-09',
free: 0,
paid: 0,
paid_canceled: 0,
paid_subscribed: 0
},
{
comped: 3,
date: '2000-01-10',
free: 2,
paid: 1,
paid_canceled: 3,
paid_subscribed: 4
}
]
+ expected - actual
[
{
- "comped": 3
+ "comped": 0
"date": "2000-01-09"
- "free": 2
- "paid": 1
+ "free": 0
+ "paid": 0
"paid_canceled": 0
"paid_subscribed": 0
}
+ {
+ "comped": 3
+ "date": "2000-01-10"
+ "free": 2
+ "paid": 1
+ "paid_canceled": 3
+ "paid_subscribed": 4
+ }
]
at Context.<anonymous> (test/lib/members.test.js:163:20)
3) MembersStatsService
getCountHistory
Correctly resolves deltas:
AssertionError [ERR_ASSERTION]: Expected values to be loosely deep-equal:
[
{
comped: 4,
date: '2000-01-08',
free: 3,
paid: 1,
paid_canceled: 0,
paid_subscribed: 0
},
{
comped: 4,
date: '2000-01-09',
free: 3,
paid: 2,
paid_canceled: 1,
paid_subscribed: 2
}
]
should loosely deep-equal
[
{
comped: 1,
date: '2000-01-08',
free: 1,
paid: 0,
paid_canceled: 0,
paid_subscribed: 0
},
{
comped: 1,
date: '2000-01-09',
free: 1,
paid: 1,
paid_canceled: 1,
paid_subscribed: 2
},
{
comped: 4,
date: '2000-01-10',
free: 3,
paid: 2,
paid_canceled: 3,
paid_subscribed: 4
}
]
+ expected - actual
[
{
- "comped": 4
+ "comped": 1
"date": "2000-01-08"
- "free": 3
- "paid": 1
+ "free": 1
+ "paid": 0
"paid_canceled": 0
"paid_subscribed": 0
}
{
- "comped": 4
+ "comped": 1
"date": "2000-01-09"
- "free": 3
- "paid": 2
+ "free": 1
+ "paid": 1
"paid_canceled": 1
"paid_subscribed": 2
}
+ {
+ "comped": 4
+ "date": "2000-01-10"
+ "free": 3
+ "paid": 2
+ "paid_canceled": 3
+ "paid_subscribed": 4
+ }
]
at Context.<anonymous> (test/lib/members.test.js:211:20)
4) MembersStatsService
getCountHistory
Correctly handles negative numbers:
AssertionError [ERR_ASSERTION]: Expected values to be loosely deep-equal:
[
{
comped: 0,
date: '2000-01-07',
free: 101,
paid: 0,
paid_canceled: 0,
paid_subscribed: 0
},
{
comped: 4,
date: '2000-01-08',
free: 103,
paid: 1,
paid_canceled: 1,
paid_subscribed: 2
},
{
comped: 4,
date: '2000-01-09',
free: 3,
paid: 2,
paid_canceled: 1,
paid_subscribed: 2
}
]
should loosely deep-equal
[
{
comped: 0,
date: '2000-01-07',
free: 1,
paid: 0,
paid_canceled: 0,
paid_subscribed: 0
},
{
comped: 1,
date: '2000-01-08',
free: 3,
paid: 0,
paid_canceled: 1,
paid_subscribed: 2
},
{
comped: 1,
date: '2000-01-09',
free: 0,
paid: 1,
paid_canceled: 1,
paid_subscribed: 2
},
{
comped: 4,
date: '2000-01-10',
free: 3,
paid: 2,
paid_canceled: 3,
paid_subscribed: 4
}
]
+ expected - actual
[
{
"comped": 0
"date": "2000-01-07"
- "free": 101
+ "free": 1
"paid": 0
"paid_canceled": 0
"paid_subscribed": 0
}
{
- "comped": 4
+ "comped": 1
"date": "2000-01-08"
- "free": 103
+ "free": 3
+ "paid": 0
+ "paid_canceled": 1
+ "paid_subscribed": 2
+ }
+ {
+ "comped": 1
+ "date": "2000-01-09"
+ "free": 0
"paid": 1
"paid_canceled": 1
"paid_subscribed": 2
}
{
"comped": 4
- "date": "2000-01-09"
+ "date": "2000-01-10"
"free": 3
"paid": 2
- "paid_canceled": 1
- "paid_subscribed": 2
+ "paid_canceled": 3
+ "paid_subscribed": 4
}
]
at Context.<anonymous> (test/lib/members.test.js:274:20)
5) MembersStatsService
getCountHistory
Ignores events in the future:
AssertionError [ERR_ASSERTION]: Expected values to be loosely deep-equal:
[
{
comped: 3,
date: '2000-01-08',
free: 1,
paid: 0,
paid_canceled: 0,
paid_subscribed: 0
},
{
comped: 3,
date: '2000-01-09',
free: 2,
paid: 1,
paid_canceled: 0,
paid_subscribed: 1
}
]
should loosely deep-equal
[
{
comped: 0,
date: '2000-01-08',
free: 0,
paid: 0,
paid_canceled: 0,
paid_subscribed: 0
},
{
comped: 0,
date: '2000-01-09',
free: 0,
paid: 0,
paid_canceled: 0,
paid_subscribed: 1
},
{
comped: 3,
date: '2000-01-10',
free: 2,
paid: 1,
paid_canceled: 3,
paid_subscribed: 4
}
]
+ expected - actual
[
{
- "comped": 3
+ "comped": 0
"date": "2000-01-08"
- "free": 1
+ "free": 0
"paid": 0
"paid_canceled": 0
"paid_subscribed": 0
}
{
- "comped": 3
+ "comped": 0
"date": "2000-01-09"
- "free": 2
- "paid": 1
+ "free": 0
+ "paid": 0
"paid_canceled": 0
"paid_subscribed": 1
}
+ {
+ "comped": 3
+ "date": "2000-01-10"
+ "free": 2
+ "paid": 1
+ "paid_canceled": 3
+ "paid_subscribed": 4
+ }
]
at Context.<anonymous> (test/lib/members.test.js:347:20)
Please help. Why are these tests failing with the latest commit from the Ghost repo
- What steps could someone else take to reproduce the issue you’re having?