Bug in the AMP output

giacomosilli · June 24, 2018, 4:21pm

Hello,
I think there is a bug with the classic editor and with the Koeing.

I try to write the following piece of code, and the whole display of the AMP page breaks down:

'$example$'

Cattura

giacomosilli · June 26, 2018, 7:28pm

Any news about it Up?

Kate · June 26, 2018, 10:28pm

Hey @giacomosilli!

I can’t reproduce what you are describing. Can you please describe steps to reproduce?

Thanks!

giacomosilli · June 26, 2018, 11:05pm

Hello, watch this video!

I recorded the steps

Download this video

Kevin · July 2, 2018, 9:27am

Hmm, this looks like it’s a bug in the AMP parser. Any thoughts @Aileen?

Kevin · July 4, 2018, 12:39pm

Hey @giacomosilli I’ve opened an issue for this bug. It’s a bug in the AMP output rather than the editor.

github.com/TryGhost/Ghost

Certain code tag content breaks AMP output

opened 12:36PM - 04 Jul 18 UTC

closed 03:04AM - 26 Jun 19 UTC

kevinansfield

bug server / core

### Issue Summary Adding `'$example$'` to the markdown truncates the AMP outp…ut before the second `$` causing broken browser rendering through missing closing tags. <img width="612" alt="screen shot 2018-07-04 at 13 33 07" src="https://user-images.githubusercontent.com/415/42277306-d645d6d8-7f8e-11e8-9052-57a4456bd0d2.png"> ### To Reproduce 1. Create a new post and set the content to: ``` Testing `'$example$'` asdf 123 ``` 2. Publish the post and open the AMP version on the blog front-end. Note the broken display and missing content after `'$example`. The HTML output is clearly malformed. the trailing `$'` is removed and the rest of the helper output is added to the bottom of the post with the final section duplicated: <img width="864" alt="screen shot 2018-07-04 at 14 07 19" src="https://user-images.githubusercontent.com/415/42279064-7733602e-7f94-11e8-9a66-f8d06ccfaac7.png"> This results in the browser injecting lots of extra `<code></code>` tags to try and deal with the malformed HTML. Removing the [SafeString](https://github.com/TryGhost/Ghost/blob/master/core/server/apps/amp/lib/helpers/amp_content.js#L200) call so that handlebars outputs the raw string appears to show that there's a nested async helper issue: ```handlebars <div class="kg-card-markdown"> <p>Testing</p> <p> <code>'$example__aSyNcId_<_ZziCMbqm__#x27;</code> asdf </p> <p>123</p> </div> ``` Narrowing the troublesome content down it appears to be caused by a trailing `$` or `$'` in any element. This can be demonstrated with simply putting `$` as the only markdown content in a post. ### Technical details: * Ghost Version: 1.24.7 * Node Version: 8.10.0 * Browser/OS: n/a * Database: SQLite

giacomosilli · July 4, 2018, 9:53pm

Well, thanks for the interest.
Good job!

system · July 19, 2018, 12:42am

This topic was automatically closed 14 days after the last reply. New replies are no longer allowed.

Topic		Replies	Views
Images are broken on AMP Developer help	5	755	July 1, 2019
[SOLVED] AMP markup missing or incorrect Developer help	1	2635	July 4, 2018
The images are not shown in the AMP post Developer help	1	619	July 10, 2018
AMP gallery does not render tags Developer help	0	287	March 26, 2020
AMP Content Not Showing Developer help	3	519	March 14, 2019

Bug in the AMP output

Related topics